New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update hmr-poc #3

Draft

hi-ogawa wants to merge 45 commits into main from hmr-poc-merge

Owner

hi-ogawa commented Nov 28, 2024 •

edited

Loading

Updating to current main so that I can also rebase rolldown/vite rolldown/vite#66

underfin added 30 commits

November 5, 2024 11:07


          feat: add hmr_rebuild api (rolldown#2137)

929dfc1

<!-- Thank you for contributing! -->

Add `hmr_rebuild(changed_file)` to using as hmr rebuild API. Here maybe
could need to return String, we could mutate it at future.

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat: store pervious build module info and using it at next hmr modul…

e4ef98f

…e loader (rolldown#2142)

<!-- Thank you for contributing! -->

Here create new `HmrModuleLoader` to scan modules which imported from
changed modules. The `changed modules` will direct spawn new task using
previous module id.

The `HmrIntermediateNormalModules` comes from the previous module info,
so here we could to re-using more logic from `ModuleLoader`.

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          chore: add react hmr example (rolldown#2147)

dd0ff89

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat: enable app format at js side (rolldown#2148)

88d239a

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          chore: disable IsolatingModuleFinalizer (rolldown#2149)

21e2270

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat: add react-refresh and make transform to commonjs work (rolldown…

20fd0ae

…#2150)

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat: render app chunk and replace require module id to stable id (ro…

9ae4e02

…lldown#2156)

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          fix: avoid wrapper runtime module at app format (rolldown#2157)

6332c0e

<!-- Thank you for contributing! -->

### Description

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          fix: using simple react refresh and make serve work (rolldown#2158)

0b129c9

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat: implement rolldown_runtime and fix react-refresh make react-exa…

4c8bc78

…mple run (rolldown#2159)

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat: implement hmr runtime (rolldown#2172)

b283d5c

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat: generate hmr chunk (rolldown#2173)

8b407cf

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          fix: diff modules ast should be mutate by IsolatingModuleFinalizer (r…

6fada77

…olldown#2184)

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat: add watcher (rolldown#2185)

681a710

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat: add server and ws (rolldown#2186)

b62ae08

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          chore(hmr): rebase main branch

44aca17


          fix(hmr): reuse symbols info for hmr (rolldown#2231)

3b3eb46

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat(hmr): remove babel @babel/plugin-transform-modules-commonjs (rol…

99333f3

…ldown#2232)

<!-- Thank you for contributing! -->

### Description

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          chore(hmr): add rebase missing changes (rolldown#2233)

135b5dc

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          fix(hmr): should replace module ast correctly at hmr (rolldown#2234)

37f0b0f

<!-- Thank you for contributing! -->

### Description

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat: using oxc react refresh (rolldown#2235)

06c747c

<!-- Thank you for contributing! -->

Run example.

1. run `just setup` to setup project.
2. build rolldown, run `just build` at project root.
3. run `npm run build` at `examples/react-hmr`.

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat(hmr): inject react refresh entry at builtin react plugin (rolldo…

52212e4

…wn#2259)

<!-- Thank you for contributing! -->

### Description

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          chore: using plugin emit html (rolldown#2260)

6a28aff

<!-- Thank you for contributing! -->

### Description

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat(app): transform export named declaration (rolldown#2264)

52cc3a1

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          fix(hmr): fix some issue for benchmark (rolldown#2265)

26ad849

<!-- Thank you for contributing! -->

### Description

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat(hmr): using virtual file to avoid write file (rolldown#2266)

47e71e6

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat(hmr): using watchpack (rolldown#2267)

14dbed0

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          feat: add vue hmr example (rolldown#2291)

6d2b895

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          fix: make sure rolldown inject runtime at vue (rolldown#2292)

ec614eb

<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          fix: escape module id at define to same as oxc codegen (rolldown#2293)

c17260b

<!-- Thank you for contributing! -->

### Description

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->

underfin and others added 5 commits

November 5, 2024 11:46


          feat: support hot accept callback (rolldown#2294)

e22e079

<!-- Thank you for contributing! -->

Run example.

1. run `just setup` to setup project.
2. build rolldown, run `just build` at project root.
3. run `npm run build` at `examples/vue-hmr`.

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->


          chore: rebase main branch

a292401


          Merge branch 'main' into hmr-poc-merge

d0e22cd


          fix: update

04c7c6f


          fix: update js

github-actions bot added the needs-triage label

hi-ogawa added 2 commits

November 28, 2024 12:34


          chore: lint

7919f5f


          fix: fix js

3f1ff73

github-actions bot commented Nov 28, 2024 •

edited

Loading

Benchmarks Rust

target: main(8ee2182)
pr: hmr-poc-merge(27d203a)

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     82.9±3.59ms        ? ?/sec    1.00     82.1±1.78ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00    107.8±3.37ms        ? ?/sec    1.02    109.9±3.20ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    121.0±3.69ms        ? ?/sec    1.03    125.0±2.25ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     89.4±2.55ms        ? ?/sec    1.00     89.4±1.28ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    132.6±3.90ms        ? ?/sec    1.02    135.3±2.91ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.02   261.3±17.61ms        ? ?/sec    1.00   255.3±10.97ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00   291.0±15.58ms        ? ?/sec    1.00   291.9±18.64ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    147.3±3.59ms        ? ?/sec    1.00    146.5±3.08ms        ? ?/sec
bundle/bundle@threejs                                               1.02     39.6±1.53ms        ? ?/sec    1.00     38.9±1.14ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.02    101.9±2.82ms        ? ?/sec    1.00     99.9±2.58ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    117.7±3.30ms        ? ?/sec    1.03    121.0±4.65ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     51.2±2.95ms        ? ?/sec    1.00     51.0±2.84ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    417.1±7.19ms        ? ?/sec    1.00    417.9±8.52ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1291.4±16.64ms        ? ?/sec    1.01  1298.1±15.18ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1510.4±13.88ms        ? ?/sec    1.01  1520.4±18.81ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    491.6±6.45ms        ? ?/sec    1.01    496.1±7.96ms        ? ?/sec
remapping/remapping                                                 1.01     28.9±0.18ms        ? ?/sec    1.00     28.6±0.20ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     75.3±0.39ms        ? ?/sec    1.01     76.3±0.36ms        ? ?/sec
scan/scan@rome-ts                                                   1.02    108.7±1.77ms        ? ?/sec    1.00    106.5±2.68ms        ? ?/sec
scan/scan@threejs                                                   1.01     30.2±0.89ms        ? ?/sec    1.00     29.9±0.52ms        ? ?/sec
scan/scan@threejs10x                                                1.01    303.7±5.35ms        ? ?/sec    1.00    299.4±4.93ms        ? ?/sec

hi-ogawa added 8 commits

November 28, 2024 12:59


          refactor: move runtime-app.js

b1b4f5b


          test: run test-node

1d8ed9e


          chore: sort package.json

d188fd1


          chore: cleanup

d89a0eb


          chore: cleanup

5f230d1


          test: cleanup

fe30379


          chore: cleanup

8a6deff


          fix: fix patch export var

27d203a

hi-ogawa mentioned this pull request

wip: integrate rolldown dev rolldown/vite#66

Draft

21 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels