-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Functionality of ESPHome Media Player #122799
base: dev
Are you sure you want to change the base?
Conversation
The ESP Media_Player needs optional supports for Next/Previous Track and Turn Off/On. That way a subclass of Media_Player can use these options to have the Media card display those widgets.
Add Clear, Enqueue, Repeat, and Shuffle
Implementation of Enqueue was not correct in previous commit. Also fixed clear_playlist
remove listen and unlisten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Thank you, its obvious now that you've pointed it out. I've signed cla with both accounts. |
I'll work on getting the files updated for ruff. A little confused because it passed ruff in my local dev environment. Most of the MyPY errors look like they are because of the changes needed from esphome/aioesphomeapi#911. How is that handled? |
I've updated the code and updated for all pre-commit requested changes from my local dev environment. I'm going to submit for review, but still unclear if it will pass tests because of changes needed from esphome/aioesphomeapi#911. Is there a way to get the github tester to use updates from another pending Pull Request? |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Drafting as this depends on upstream changes. |
Breaking change
No breaking change
Proposed change
What does this implement/fix?
Lays the ground work for child components of Esphome Media Player to be built with a richer set of capability.
Description
Extends Esphome Media Player component to support the following commands in child components:
Traits are extended to include:
Type of change
Additional information
Requires the following pull requests:
esphome/esphome-docs#4090
esphome/aioesphomeapi#911
esphome/esphome#7158
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
Nothing changes for existing esphome media_players, new functionality requires updated/new esphome components.
An example of which is my external component https://github.com/rwrozelle/audio-media-player
Documentation updated on esphome.io repository.
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: