-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update description of the script toggle action #134093
base: dev
Are you sure you want to change the base?
Conversation
The 'Script: Toggle' action repeats that as "Toggle a script. …" in its description. This should be "Toggles …" to be consistent with the descriptions of the other Script actions. But actually the other two also don't repeat "Turn on" or "Turn off" either but explain the actual result, too. Thus we can simply drop that part and reword the rest. This also fixes the wrong comma before "if".
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Dave T <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @NoRi2909
Proposed change
The 'Script: Toggle' action repeats that as "Toggle a script. …" in its description. This should be "Toggles …" to be consistent with the descriptions of the other Script actions that use "Runs …" and "Stops …"
But actually the other two also don't repeat "Turn on" or "Turn off" either, but explain the actual result, too.
Thus we can simply drop that part and reword the rest. This also fixes the wrong comma before "if".
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: