[WIP] Add ES Auto Index Cleaner #6425
Draft
+121
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alok Kumar Singh <[email protected]>
Signed-off-by: Alok Kumar Singh <[email protected]>
Signed-off-by: Alok Kumar Singh <[email protected]>
akstron
force-pushed
the
es-index-cleaner
branch
from
8feef9c to
6370ca0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6425 +/- ##
===========================================
- Coverage 96.20% 34.64% -61.57%
===========================================
Files 356 192 -164
Lines 20416 11643 -8773
===========================================
- Hits 19642 4034 -15608
- Misses 585 7301 +6716
- Partials 189 308 +119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
akstron
commented
Dec 27, 2024
| i.logger.Info("Indices before this date will be deleted", zap.String("date", deleteIndicesBefore.Format(time.RFC3339))) | ||
|
|
||
| indices = filter.ByDate(indices, deleteIndicesBefore) | ||
|
|
There was a problem hiding this comment.
Will add check to not delete indices with write alias.
yurishkuro
reviewed
Dec 28, 2024
| @@ -41,6 +44,32 @@ type IndicesClient struct { | |||
| MasterTimeoutSeconds int | |||
| } | |||
|
|
|||
| // Create the indices only client using config.Configuration | |||
| func CreateIndicesClient(c *config.Configuration, logger *zap.Logger) (*IndicesClient, error) { | |||
There was a problem hiding this comment.
I don't follow why we need this function. The pattern in es.Factory is to use config.NewClient, which takes configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test