Voxel demo #65
Voxel demo #65
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
js-pkg/react/src/main.tsx
Outdated
| excludeSelf?: boolean | ||
| } | ||
|
|
||
| export function usePresence<T extends Record<string, any>>( |
There was a problem hiding this comment.
this change should be in another pr
There was a problem hiding this comment.
I tend to agree actually, opened #66.
There was a problem hiding this comment.
Why do you think so?
So it's easier to revert in isolation, since we squash commits.
| "@react-three/drei": "^9.80.2", | ||
| "@react-three/fiber": "^8.13.6", | ||
| "@types/react-color": "^3.0.6", | ||
| "@uiw/react-color": "^1.3.3", |
There was a problem hiding this comment.
Why not use react-color?
I don't know if this is related, but I noticed the color picker is off:
There was a problem hiding this comment.
react-color hasn't been touched in two years and causes noisy warnings with recent versions of react (github issue)
There was a problem hiding this comment.
what do you mean by "off"?
There was a problem hiding this comment.
oh, I see what you mean, the colors don't line up by column
js-pkg/react/src/main.tsx
Outdated
| const awareness = useAwareness() | ||
| const [presence, setPresence] = useState<Map<number, T>>(new Map()) | ||
|
|
||
| const excludeSelf = options?.excludeSelf ?? true |
There was a problem hiding this comment.
Minor, but if the default is to exclude self, maybe this option could be called includeSelf?
There was a problem hiding this comment.
good call, I like the principle that bools should be oriented such that the default is false.
Demo: https://y-sweet-demos-git-paulgb-voxel-demo-drifting-corp.vercel.app/voxels