add response message when token black listed. #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…token' into add-return-message-in-blacklist-token # Conflicts: # rest_framework_simplejwt/views.py
for more information, see https://pre-commit.ci
50-Course
requested changes
May 2, 2024
rest_framework_simplejwt/views.py
Outdated
Comment on lines
121
to
122
| serializer_data = response.data | ||
| serializer_data['Token detail'] = 'Token blacklisted' |
There was a problem hiding this comment.
This should be changed to match a descriptive message such as that in the test, Token detail should be message.
Can you send in a fix?
serializer_data['message'] = 'Token blacklisted'There was a problem hiding this comment.
Hi thanks for your attention, sure as soon as possible
50-Course
approved these changes
May 2, 2024
There was a problem hiding this comment.
thank you for this patch @amirdjango, just found out the changed had been effected in a newer commit, and had revised my review 🚀
rest_framework_simplejwt/views.py
Outdated
| @@ -119,7 +119,7 @@ class TokenBlacklistView(TokenViewBase): | |||
| def post(self, request: Request, *args, **kwargs) -> Response: | |||
| response = super().post(request, *args, **kwargs) | |||
| serializer_data = response.data | |||
| serializer_data['Token detail'] = 'Token blacklisted' | |||
| serializer_data['message'] = 'Token blacklisted' | |||
|
Just did a bisect on the failing pipeline, it so happen that two tests are breaking
Since the requirements had grown, I think we should revisit these tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.