Comment out conferences with broken links #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
requested changes
Jan 7, 2020
| site: https://2019.jsconf.us | ||
| logo: https://2015.jsconf.us/img/js-sized.png | ||
| location: Carlsbad, California | ||
| # - jsconfus: |
There was a problem hiding this comment.
This is still active, but I pinged them
| site: http://empireconf.org | ||
| logo: images/empirejs/2015.png | ||
| location: New York, NY | ||
| # - empirejs: |
There was a problem hiding this comment.
Could we instead only remove the link?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its current state, the site seems a bit broken, since there are multiple conferences listed with DNS records that go nowhere (not to mention some broken images). This PR is not removing those conferences from the YAML file, but I am commenting them out to be removed from the listing until the sites are updated. Additionally, a couple of them are configured to be in a persistent state of "on sale".
Here are the conferences I'm commenting out:
Please let me know if there are any questions/concerns about this change.