Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Google Calendar iframe #571

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Responsive Google Calendar iframe #571

merged 2 commits into from
Dec 29, 2021

Conversation

palewire
Copy link
Collaborator

@palewire palewire commented Dec 28, 2021

The Google Calendar iframe on the /community page is now a fixed width, which breaks at mobile sizes.

This change follows the W3C advice for making it responsive at a 4:3 aspect ratio. There is no change to the content.

@palewire palewire added this to the Streamline the site milestone Dec 28, 2021
@krassowski
Copy link
Member

Let's not mistake W3Schools for W3C (see https://www.w3fools.com/).

After the change the calendar may be too small on some devices:

Screenshot from 2021-12-29 02-55-10

In particular:

  • after switching to week view it is not possible to switch back to the month view (I don't see a way to fix it)
  • we will only see "+n more" for most days on most of the devices; we can fix this by changing the padding-top to e.g. 130%, which gives good results for most typical test phones:

Screenshot from 2021-12-29 03-03-57

@palewire
Copy link
Collaborator Author

I can try that padding jimmy. I think we gotta do something responsive here. This is the current look, which I would call a bug.

Screenshot_20211228-194530

@krassowski
Copy link
Member

This is the current look, which I would call a bug.

Yes, I agree that this is not great. Maybe we could consider using an alternative to Google Calendar which is fully privacy-respecting and responsive?

@krassowski
Copy link
Member

One option would be https://fullcalendar.io/ which supports fetching from public Google Calendar: https://fullcalendar.io/docs/google-calendar.

@palewire
Copy link
Collaborator Author

@krassowski, I've added a taller mobile aspect ratio for you, and made a new ticket about Google Calendar.

#574

@palewire
Copy link
Collaborator Author

Here's the new mobile look.

Screenshot from 2021-12-29 06-18-33

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@palewire palewire merged commit 1dbf84c into master Dec 29, 2021
@krassowski krassowski deleted the responsive-iframe branch May 26, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants