Experiment with threadpools #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| check_patch_tornado() | ||
| return loop.run_until_complete(coro) | ||
|
|
||
| return pool.submit(asyncio.run, coro).result() |
There was a problem hiding this comment.
We could have only this line in the function, so that we always run in a thread with its own event loop.
| @@ -28,6 +30,7 @@ def check_patch_tornado() -> None: | |||
| tornado.concurrent.FUTURES = \ | |||
| tornado.concurrent.FUTURES + (asyncio.Future, ) # type: ignore | |||
|
|
|||
| pool = concurrent.futures.ThreadPoolExecutor() | |||
There was a problem hiding this comment.
Any reason to use more than one thread? I think we should use max_workers=1.
There was a problem hiding this comment.
max_worker should be fine IMO.
There was a problem hiding this comment.
If you don't specify mar_workers, it will use unnecessary resources: "If max_workers is None or not given, it will default to the number of processors on the machine, multiplied by 5".
Since you never actually run concurrently, you don't need more than 1 thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am seeing many issues with nest-asyncio. Trying out threadpools.