Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chat links to Zulip. #7539

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Update chat links to Zulip. #7539

merged 5 commits into from
Dec 20, 2024

Conversation

ericsnekbytes
Copy link
Collaborator

Updated the issue template chat link and docs page header icons to point to Zulip.

@ericsnekbytes ericsnekbytes requested a review from jtpio December 12, 2024 16:39
Copy link
Contributor

Binder 👈 Launch a Binder on branch ericsnekbytes/notebook/zulip_docs

@jtpio jtpio added this to the 7.3.x milestone Dec 12, 2024
@jtpio
Copy link
Member

jtpio commented Dec 18, 2024

Thanks @ericsnekbytes!

Looks like the CI failures are not related. Looks like they should have been fixed by jupyter/jupyter_events#103.

@jtpio
Copy link
Member

jtpio commented Dec 18, 2024

Looks like the CI failures are not related. Looks like they should have been fixed by jupyter/jupyter_events#103.

Actually they are still failing, but with a different error.

@Carreau
Copy link
Member

Carreau commented Dec 19, 2024

The failure are due to a requested change: jupyter/jupyter_events#104

Version should now be a str (not an int).

@Carreau
Copy link
Member

Carreau commented Dec 19, 2024

jupyter-server/jupyter_server#1481 should fix it... but I need review, and merge and release.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit d9119b8 into jupyter:main Dec 20, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants