-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Promote feature CRS to GA #11365
base: main
Are you sure you want to change the base?
✨ Promote feature CRS to GA #11365
Conversation
/cc fabriziopandini |
b5a503b
to
653f6f0
Compare
@mcbenjemaa It would be nice if we can rebase this PR I'm personally +1, considering we did a good work to define scope and limitations of this feature in the last iteration on https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20200220-cluster-resource-set.md + we have https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20220712-cluster-api-addon-orchestration.md in case someone something more sophisticated. |
I'm good with getting this to GA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: f93d562e33f79fc162196a0d5d62e257a96a5ad4
|
So this should go to v1.9 or to the next one? |
We are not in rush, Let's move to 1.10 |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from my side, just nits
// ClusterResourceSet is the Schema for the clusterresourcesets API | ||
// it provides a basic solution for installing & managing resources | ||
// while for advanced use cases an addon provider must be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// ClusterResourceSet is the Schema for the clusterresourcesets API | |
// it provides a basic solution for installing & managing resources | |
// while for advanced use cases an addon provider must be used. | |
// ClusterResourceSet is the Schema for the clusterresourcesets API. | |
// For advanced use cases an add-on provider should be used instead. |
The sentence in-between does not really help explaining why it is a basic solution.
@@ -39,6 +39,7 @@ const ( | |||
// | |||
// alpha: v0.3 | |||
// beta: v0.4 | |||
// GA: v1.10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// GA: v1.10. | |
// GA: v1.10 |
What this PR does / why we need it:
Promote ClusterResourceSet to GA,
Make the CRS feature GA and enabled by default, and make the CRS feature clear in the API and documentation.
the code organization will be held in following PR after this is released
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Ref #11114
/area api
/area clusterresourceset
/area documentation