-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add Go section to install clusterctl #11464
base: main
Are you sure you want to change the base?
📖 Add Go section to install clusterctl #11464
Conversation
Signed-off-by: sivchari <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ah, sorry. Presumably, we can't embed the some versions via ldflags option if we use |
An alternative would be to make clusterctl not fail when the ld flags have not been set. Afaik they are only used for the version subcommand (which should be okay) and as post run to check for new versions. |
I think it's prefer the way you propose. So I'd open the issue to discuss about it. |
|
||
Test to ensure the version you installed is up-to-date: | ||
```bash | ||
clusterctl version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this work for you?
It didn't for me:
$ go install sigs.k8s.io/cluster-api/cmd/clusterctl@latest
go: downloading sigs.k8s.io/cluster-api v1.9.3
$ ~/code/bin/clusterctl version
clusterctl version: &version.Info{Major:"", Minor:"", GitVersion:"", GitCommit:"", GitTreeState:"", BuildDate:"", GoVersion:"go1.22.1", Compiler:"gc", Platform:"darwin/arm64"}
What this PR does / why we need it:
I added the Go section to install clusterctl via go install.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area documentation