-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ clusterctl: Add support for valid GitHub URLs #11595
base: main
Are you sure you want to change the base?
✨ clusterctl: Add support for valid GitHub URLs #11595
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @HomayoonAlimohammadi! |
Hi @HomayoonAlimohammadi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Following this already closed issue, URLs in the
clusterctl
config are invalid and do not point to any resource. This PR adds the support for having valid URLs while also keeping backwards compatibility by supporting the old (invalid) format.Which issue(s) this PR fixes:
In #2830, the invalid URL part was seemingly ignored in the mentioned issue.
/area clusterctl