feat: Add ability to migrate owner ID when using the TXT registry

[mkilchhofer]

Description

This is a follow up of the stale PR over there:

• New features: migrate txt-owner #2466

As the contributor @Inorysky is no longer active in the initial PR, I forked his/hers work into our organization, rebased and added a unit test.

Initial PR description:

Description

When changing --txt-owner-id on an existing external-dns resource, it does not update the existing TXT records it owns, therefore losing ownership. Meaning that we have to manually delete the records in order to have external-dns take ownership again.
To solve this problem, I added the ability to update the original txt-owner by setting -- migrate-txt-owner to overwrite the old txt-owner. I have successfully modified thousands of pieces of data using this code, so far without any bugs.

Fixes #ISSUE #2036

Source: github.com/kubernetes-sigs/external-dns/pull/2466

I tested this feature also manually on:

• AWS Route 53
• DigitalOcean DNS

Fixes #2036

Checklist

• Unit tests updated
• End user documentation updated

[linux-foundation-easycla]

• ✅login: mkilchhofer / (0e3b9fb)
• ✅login: Inorysky / (53586c6)
• ✅login: Inorysky / (53586c6, 54c9328)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkilchhofer
Once this PR has been reviewed and has the lgtm label, please assign njuettner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @mkilchhofer!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mloiseleur]

Hello @mkilchhofer ,

Do you think you can sign the CLA & rebase this PR ?

[mloiseleur]

No activity and no response in the last month.
=> I'm closing this PR.
Feel free to re-open it if/when you have time.
/close

[k8s-ci-robot]

@mloiseleur: Closed this PR.

In response to this:

No activity and no response in the last month.
=> I'm closing this PR.
Feel free to re-open it if/when you have time.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[splichy]

@mkilchhofer could you please consider signing CLA, or if you agree I can fork and rebase your commit as mine and open a new PR. But I don't want to steal your work ;)

[alen-z]

What is happening here folks? Number of attempts failed. Not a most favorable solution, community issue, organizational issue? This feature could be impactful 👍

[aallawala]

+1, I can also drive the work if we're just waiting on a CLA

@mkilchhofer, are you okay if one of us rebased your commits and tried to contribute again to this?

[mkilchhofer]

@mkilchhofer, are you okay if one of us rebased your commits and tried to contribute again to this?

Sure yes 👍