chore: temporary dirs are created under PWD

[david-barbion]

Git can be configured per directory using the includeIf statement in ~/.gitconfig. This allows per-customer (if you have many clients for whom you work) ssh key.

Up to now, kustomize builds its yaml in /tmp/kustomize- prefixed directory. Per say, no .gitconfig on that directory.

This patch instructs kustomize to use $PWD/kustomize- prefixed directory.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: david-barbion / name: David Barbion (2c1fd98)

[k8s-ci-robot]

Welcome @david-barbion!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @david-barbion. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: david-barbion
Once this PR has been reviewed and has the lgtm label, please assign knverey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[koba1t]

/assign @koba1t

[koba1t]

Hi @david-barbion

In my understanding, a function of remote manifests pull with git clone in kustomize exec git command in your computer, and that reads your git setting like ~/.gitignore file.
https://github.com/kubernetes-sigs/kustomize/blob/master/examples/remoteBuild.md

Could you please elaborate on what this PR is trying to solve?

BTW, This change would be difficult to merge as is because it would be breaking change the existing user's environment.

[david-barbion]

Hi @david-barbion

In my understanding, a function of remote manifests pull with git clone in kustomize exec git command in your computer, and that reads your git setting like ~/.gitignore file. https://github.com/kubernetes-sigs/kustomize/blob/master/examples/remoteBuild.md

Could you please elaborate on what this PR is trying to solve?

BTW, This change would be difficult to merge as is because it would be breaking change the existing user's environment.

Hi @koba1t ,

Actually, I have to manage many git identities (one for each customer for whom I work). That means: a different git ssh key, email, ... To achieve this, I use the includeIf statement that permits to set a different ssh key, different email per directory:

[includeIf "gitdir:~/work/client1/"]
  path = ~/work/client1/.gitconfig
[includeIf "gitdir:~/work/client2/"]
  path = ~/work/client2/.gitconfig

[includeIf "gitdir:/tmp/"]
  path = ~/work/client1/.gitconfig
#  path = ~/work/client2/.gitconfig

and here the file ~work/client1/.gitconfig as an example:

[user]
	name = David Barbion
	email = [email protected]
	signingKey = ""
[url "ssh://[email protected]/"]
	insteadOf = https://gitlab.com/
[protocol "file"]
	allow = always
[core]
  sshCommand = "ssh -i ~/.ssh/id_ed25519_client1 -F /dev/null"

The way kustomize clones a git is done in a /tmp (or /private location for MacOs). See the last includeIf in the first code block. I have to switch the path depending where I'm currently working.

This PR is mainly for my convenience and totally understand if it could be not be accepted as is. Maybe by adding a command line flag which indicates where to set temp dir.

During my investigation, I stumbled upon TMPDIR which os.MkdirTemp() uses to set the root temp dir. But that needs to set an envvar...