[11.x] First class callable syntax #53806
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
reviewed
Dec 9, 2024
| @@ -38,7 +38,7 @@ public function handle(PackageManifest $manifest) | |||
|
|
|||
| (new Collection($manifest->manifest)) | |||
| ->keys() | |||
| ->each(fn ($description) => $this->components->task($description)) | |||
| ->each($this->components->task(...)) | |||
There was a problem hiding this comment.
This looks like it could be a breaking change?
$this->components->task method will receive the $description as it previously did but it will also receive the each callbacks $index as the second parameter, where it is expecting a callable.
There was a problem hiding this comment.
Confirmed this is a breaking change.
There was a problem hiding this comment.
Whoops, totally missed that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some redundant anonymous functions and replaces it with PHP's first class callable syntax, improving readability a bit.