Refactor email template to use Blade syntax instead of raw PHP #54028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaedrich
reviewed
Dec 27, 2024
Comment on lines
+21
to
+26
| @php | ||
| $color = match ($level) { | ||
| 'success', 'error' => $level, | ||
| default => 'primary', | ||
| }; | ||
| ?> | ||
| @endphp |
There was a problem hiding this comment.
You could also do
Suggested change
| @php | |
| $color = match ($level) { | |
| 'success', 'error' => $level, | |
| default => 'primary', | |
| }; | |
| ?> | |
| @endphp | |
| @php($color = in_array($test, ['success', 'error']) ? $level : 'primary') |
There was a problem hiding this comment.
Yes, it is possible to refactor this code as you wrote it, but I think it was written this way for extensibility and customization by developers. (match is used)
There was a problem hiding this comment.
In that case, the logic shouldn't be in the template at all in the first place but in a method to be called in the template
There was a problem hiding this comment.
Using inline @php statements is no longer recommended nor documented.
References:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.