Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Marching Ants animation to docs #393

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

Alero-Awani
Copy link
Contributor

@Alero-Awani Alero-Awani commented Oct 17, 2024

Notes for Reviewers

This PR fixes #337

Also changed the embedded design in the Embedding Designs doc to a better design.

image

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 5632542
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/6718e89cd852a600084ffdbe
😎 Deploy Preview https://deploy-preview-393--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@fitzergerald fitzergerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality work, @Alero-Awani.

Is there an existing section with code snippet that needs to be replaced?

@leecalcote
Copy link
Member

Quality work, @Alero-Awani.

Is there an existing section with code snippet that needs to be replaced?

I thought that we had a yaml or json example in here somewhere. It can make sense to continue to have as a behind-the-scenes way of setting this animation (instead of using the mouse to do it), but we'll need to make sure the it is still set in the same way. I don't think that it is. Soooo, we'll either need to delete or update.

@vishalvivekm
Copy link
Contributor

@Alero-Awani
Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@vishalvivekm
Copy link
Contributor

@Alero-Awani Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

adding

@leecalcote
Copy link
Member

Quality work, @Alero-Awani.

Is there an existing section with code snippet that needs to be replaced?

@Alero-Awani
Copy link
Contributor Author

@leecalcote This embedded design needs to be replaced with a more complex design. I'll do that and include it in this PR.

Signed-off-by: Alero Awani <[email protected]>
@leecalcote leecalcote merged commit deb342d into layer5io:master Oct 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants