Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the App Bar section #6036

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

NishantSinghhhhh
Copy link
Contributor

@NishantSinghhhhh NishantSinghhhhh commented Oct 27, 2024

Description:

This PR introduces detailed documentation for the App Bar component, outlining its purpose, usage, and customizable options. The documentation provides insights into different App Bar variations, including configurations for Basic App Bar, App Bar with Menu, and App Bar with integrated Search functionality. Developers can now gain a comprehensive understanding of how to implement the App Bar effectively, tailor it to specific use cases, and maintain visual and functional consistency across the application.

Changes Include:

1-Overview of App Bar component’s purpose and primary function in guiding navigation and user interactions.
2-Descriptions of various App Bar types and scenarios best suited for each, such as Basic App Bar, App Bar with Menu, and App Bar with Search.
3-Detailed guidelines for content structure, icon/button usage, and design considerations to ensure a cohesive user experience.
4-Example implementations for each App Bar variation to demonstrate practical usage and customizations.
5-Accessibility best practices and recommendations for color, contrast, and iconography to align with UI standards.

Changes other then This:
1- I have added 1 component in Reusecore , the component is code-block.js , It will be used in each and every component , thus creating new code-block.js for every component is not a good idea , thus came up with a component

Notes for Reviewers:
Please review the examples and descriptive content for clarity and completeness. Feedback on additional use cases or any modifications to styling or accessibility guidelines would be greatly appreciated.

Issue Number : ##5902

Signed commits

  • Yes, I signed my commits.

Signed-off-by: NishantSinghhhhh <[email protected]>
@github-actions github-actions bot added area/projects An issue relating to Layer5 initiatives (projects) project/sistent labels Oct 27, 2024
@l5io
Copy link
Contributor

l5io commented Oct 27, 2024

🚀 Preview for commit 86f1a0f at: https://671e720d8a0d5368cb7ce4be--layer5.netlify.app

@nebula-aac nebula-aac self-requested a review October 27, 2024 17:29
@vishalvivekm
Copy link
Contributor

@NishantSinghhhhh
Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@NishantSinghhhhh
Copy link
Contributor Author

NishantSinghhhhh commented Oct 28, 2024

Sir today I will be travelling back to my hometown, so I am really sorry, but I won't be able to attend the meet , is there any other way around?

@NishantSinghhhhh
Copy link
Contributor Author

@sudhanshutech @vishalvivekm z can you review the PR

@sudhanshutech
Copy link
Member

@NishantSinghhhhh merge conflicts

@l5io
Copy link
Contributor

l5io commented Oct 30, 2024

🚀 Preview for commit 02a8ce3 at: https://672224ec00d5ef9335e8329e--layer5.netlify.app

Signed-off-by: NishantSinghhhhh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 30, 2024

🚀 Preview for commit 4c32044 at: https://67223878fce926067d7afd72--layer5.netlify.app

Signed-off-by: NishantSinghhhhh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 30, 2024

🚀 Preview for commit 0960ec0 at: https://67223e744861b90c310ffd50--layer5.netlify.app

NishantSinghhhhh and others added 2 commits November 9, 2024 17:00
Signed-off-by: NishantSinghhhhh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Nov 9, 2024

🚀 Preview for commit 36db130 at: https://672f4b1f7fd1e31e6446bb32--layer5.netlify.app

@NishantSinghhhhh
Copy link
Contributor Author

@sudhanshutech sir can you review the changes that I have done

@l5io
Copy link
Contributor

l5io commented Nov 18, 2024

🚀 Preview for commit 11b7f18 at: https://673b3c67fd3db1174baa05d9--layer5.netlify.app

@sudhanshutech
Copy link
Member

change the structure of page as per new changes made around adding sistent components

@sudhanshutech
Copy link
Member

@NishantSinghhhhh are you completing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/projects An issue relating to Layer5 initiatives (projects) project/sistent
Development

Successfully merging this pull request may close these issues.

5 participants