style(tabs): add styling to tabs #833
Closed
+33
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankita Sahu <[email protected]>
|
@SAHU-01 can you share some screenshot how does it look? |
sudhanshutech
requested changes
Dec 3, 2024
|
Thanks for this feedback, @sudhanshutech |
Signed-off-by: Ankita Sahu <[email protected]>
src/theme/components/tab.modifier.ts
Outdated
| styleOverrides: { | ||
| root: ({ theme }) => ({ | ||
| backgroundColor: 'transparent', | ||
| color: theme.palette.text.primary, |
There was a problem hiding this comment.
do we not have any token to use it in here?
| color: theme.palette.text.primary, | ||
| '&.Mui-selected': { | ||
| backgroundColor: 'transparent', | ||
| color: theme.palette.mode === 'dark' ? GRAY : GRAY |
There was a problem hiding this comment.
Sure, I've set it to none. I couldn't find a token that makes it transparent so I updated it to 'none'.
Signed-off-by: Ankita Sahu <[email protected]>
Signed-off-by: Ankita Sahu <[email protected]>
Signed-off-by: Ankita Sahu <[email protected]>
There was a problem hiding this comment.
@SAHU-01 don't use hard code colors names like gray or white instead use tokens
Thank you for highlighting I'll add these today and update the PR. |
|
@SAHU-01 i have added the theme for tabs , test that in meshery and if everything looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR adds styling to sistent tabs.
Signed commits