Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(box): add forwardRef to box component #859

Merged
merged 63 commits into from
Dec 27, 2024
Merged

fix(box): add forwardRef to box component #859

merged 63 commits into from
Dec 27, 2024

Conversation

capricorn-32
Copy link
Contributor

@capricorn-32 capricorn-32 commented Dec 22, 2024 •
edited
Loading

Notes for Reviewers

This PR fixes #
Added forwardRef to all the sistent base component

Signed commits

  • Yes, I signed my commits.

@aabidsofi19
Copy link
Contributor

aabidsofi19 commented Dec 22, 2024 •
edited
Loading

@capricorn-32 there are some lint failures , rest you are on right path

@capricorn-32
Copy link
Contributor Author

@aabidsofi19 In Avatar component right or In other component ?

@Ajay-singh1
Copy link
Member

@capricorn-32 You forgot to sign your commits!

@capricorn-32
Copy link
Contributor Author

@Ajay-singh1 there is ton of work left and I will do that in the end.

@sudhanshutech
Copy link
Member

@capricorn-32
Let's discuss this during the website call on Monday at 6:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@capricorn-32
fix(box): add forwardRef to box component
4db26b2 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Accordion): add forwardRef to Accordion component
e7c9720 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(AccordionActions): add forwardRef to AccordionActions component
e534575 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(AccordionDetails): add forwardRef to AccordionDetails component
f40d859 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(AccordionSummary): add forwardRef to AccordionSummary component
f7dfca9 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(AppBar): add forwardRef to AppBar component
bcb1bd9 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Avatar): add forwardRef to Avatar component
e83604b 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(AvatarGroup): add forwardRef to AvatarGroup component
038e9c3 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Backdrop): add forwardRef to Backdrop component
690f733 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Avatar): Component now imported default like other components
4ef75f4 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Badge): add forwardRef to Badge component
9ec9901 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(ButtonGroup): add forwardRef to ButtonGroup component
265efd1 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Card): add forwardRef to Card component
0b233ae 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(CardActions): add forwardRef to CardActions component
3194625 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(CardContent): add forwardRef to CardContent component
de1fc1e 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(CardHeader): add forwardRef to CardHeader component
93273e3 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(CardMedia): add forwardRef to CardMedia component
f65f38f 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(CheckBox): add forwardRef to CheckBox component
4335d71 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(CheckBox): typeError fixed
b82a8b1 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Chip): add forwardRef to Chip component
0906425 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(CircularProgress): add forwardRef to CircularProgress component
680320f 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(ClickAwayListener): add forwardRef to ClickAwayListener component
af05e5f 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Collapse): add forwardRef to Collapse component
b05c0e6 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Container): add forwardRef to Container component
cd6304e 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Dialog): add forwardRef to Dialog component
d62017b 
Signed-off-by: seniorliketocode <[email protected]>
capricorn-32 and others added 26 commits December 25, 2024 18:39
@capricorn-32
fix(ListItemButton): add forwardRef to ListItemButton component
56d3c7f 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(ListItemIcon): add forwardRef to ListItemIcon component
5594081 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(ListItemSecondaryAction): add forwardRef to ListItemSecondaryActi…
0302533 
…on component

Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(ListItemText): add forwardRef to ListItemText component
fdc64e4 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Menu): add forwardRef to Menu component
4a93854 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(OutlinedInput): add forwardRef OutlinedInput component
37c7527 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
Merge branch 'master' into fix/forwardRef
2424cb7
@capricorn-32
fix(Pagination): add forwardRef Pagination component
85eab66 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
Merge branch 'fix/forwardRef' of github.com:capricorn-32/sistent into…
01c575f 
… fix/forwardRef
@capricorn-32
fix(Paper): add forwardRef Paper component
e3b9b87 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Popper): add forwardRef Popper component
c5add03 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(RadioGroup): add forwardRef RadioGroup component
891c885 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Select): add forwardRef Select component
98ce6b2 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Skeleton): add forwardRef Skeleton component
2fb5373 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Slide): add forwardRef Slide component
bc3c4d0 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(ListItemButton): add forwardRef ListItemButton component
7f1ac9c 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(stack): add forwardRef stack component
43f0955 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Button): add forwardRef Button component
ceee657 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Tab): add forwardRef Tab component
6e055f3 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Tabs): add forwardRef Tabs component
5f75b68 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(TextField): add forwardRef TextField component
f2f9a3d 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(ToggleButtonGroup): add forwardRef ToggleButtonGroup component
72bf79d 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Toolbar): add forwardRef Toolbar component
7d392c8 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Tooltip): add forwardRef Tooltip component
5315216 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(Typography): add forwardRef Typography component
95fb0c6 
Signed-off-by: seniorliketocode <[email protected]>
@capricorn-32
fix(bug): revert some component which doesn't support forwardRef
d547a36 
Signed-off-by: seniorliketocode <[email protected]>
@aabidsofi19
Copy link
Contributor

ready to merge ?

@capricorn-32
Copy link
Contributor Author

@aabidsofi19 Wait

@capricorn-32
Copy link
Contributor Author

@aabidsofi19 Yes, we can merge this.

@aabidsofi19 aabidsofi19 merged commit 3cf7ecb into layer5io:master Dec 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@capricorn-32 @aabidsofi19 @Ajay-singh1 @sudhanshutech