feat(webrtc): implement fin ack #5687
Conversation
|
Thank you for your contribution @tesol2y090 and sorry for the delay here! Will try to give this a review in the next days. |
misc/webrtc-utils/src/stream.rs
Outdated
| // Check if we've received FIN_ACK or deadline has passed | ||
| if self.state.fin_ack_received() | ||
| || self | ||
| .fin_ack_deadline | ||
| .is_some_and(|deadline| Instant::now() >= deadline) | ||
| { | ||
| if !self.state.fin_ack_received() { | ||
| tracing::warn!("FIN_ACK timeout, forcing close"); | ||
| } |
There was a problem hiding this comment.
Can we do early returns instead of nested if-statements here?
misc/webrtc-utils/src/stream.rs
Outdated
| .expect("to not close twice") | ||
| .send(GracefullyClosed {}); | ||
| // Check if we've received FIN_ACK or deadline has passed | ||
| if self.state.fin_ack_received() |
There was a problem hiding this comment.
Not sure about this, but don't we need to somehow continue reading here to be able to receive the FIN_ACK?
With AsyncWriteExt for instance a future will be created that only returns after poll_close succeeded i.e. no concurrent call to poll_read happens. With the current impl, I don't think a FIN_ACK will ever be read in that case?
On the other hand, we'd then have to discard the read messages or buffer them. Not sure how this is handled e.g. in QUIC, or in the go implementation.
| /// FIN_ACK timeout | ||
| const FIN_ACK_TIMEOUT: Duration = Duration::from_secs(10); |
There was a problem hiding this comment.
Is this number part of specs or was discussed somewhere?
This is time that we'll have to wait each time when closing a stream if the remote doesn't support FIN_ACK right?
There was a problem hiding this comment.
Yes, that's right. I follow the go-libp2p implementation. https://github.com/libp2p/go-libp2p/blob/master/p2p/transport/webrtc/stream.go#L45
Description
Implements FIN_ACK support for WebRTC streams to ensure reliable closure handshaking as specified in the WebRTC spec. This adds:
FIN_ACK#4600Notes & open questions
Instantfor deadline tracking instead of tokio timer to avoid extra dependenciesChange checklist