Revert "Do not create build requests for workers if offline longer than 30 minutes."

[nickdesaulniers]

This reverts commit 618344c and fab27e2.

Otherwise we observe the failure in presubmit:
$ cd buildbot/osuosl/master && BUILDBOT_TEST=1 buildbot checkconfig
Configuration Errors:
Unknown BuildmasterConfig key ignoreOfflineWorkersTimeout

FWICT, ignoreOfflineWorkersTimeout is not documented anywhere. It has been implied that LLVM's buildbot has downstream patches. I could not find where these were published, and the issue is now blocking me from further updates to CI. Rip everything out for now.

LLVM's buildbot seems to be deploying a forked version

Link: 618344c

[nickdesaulniers]

For more context, whatever llvm-zorg presubmit is running, it doesn't have this downstream buildbot change. Example: https://github.com/llvm/llvm-zorg/actions/runs/12128581722/job/33867538253?pr=325

[asb]

For more context, whatever llvm-zorg presubmit is running, it doesn't have this downstream buildbot change. Example: https://github.com/llvm/llvm-zorg/actions/runs/12128581722/job/33867538253?pr=325

It's running buildbot 3.11.7 (see here) which matches current requirements.in), except the main 'buildbot' package is a fork that's checked out locally that seems not to be uploaded anywhere.

I'm seeing pre-commit tests green in #325 and others so I'm not sure this revert is necessary at this point? I think you may have been having failures prior to rebasing the PR / merging in latest changes?

I'm sorry the precommit tests have added friction here - I think having this capability is still a big improvement over what we had before (no testing), but would for sure be better if we can sort out this issue with the non-reproducibility of LLVM's buildbot deployment. As discussion on this has spanned a few PRs now, I've filed #331 on the specific topic of sharing the source of the deployed buildbot fork/downstream branch.

[nickdesaulniers]

It's running buildbot 3.11.7 (see here) which matches current requirements.in), except the main 'buildbot' package is a fork that's checked out locally that seems not to be uploaded anywhere.

pip install buildbot{,-worker}==3.11.7 urllib3

Wont that install upstream buildbot, not a downstream fork?

---

#325 has passed presubmit somehow, so closing this.

[asb]

It's running buildbot 3.11.7 (see here) which matches current requirements.in), except the main 'buildbot' package is a fork that's checked out locally that seems not to be uploaded anywhere.

pip install buildbot{,-worker}==3.11.7 urllib3

Wont that install upstream buildbot, not a downstream fork?

#325 has passed presubmit somehow, so closing this.

Yes, sorry I wasn't clear. I mean that requirements.in uses 3.11.7 for all the other buildbot components, except for the main 'buildbot' package which is a local repo of unknown (to me) contents. I match the 3.11.7 version in the presubmit testing and local testing config I set up. 'Fixes' like #313 just skip llvm fork-only settings in "local testing mode". This isn't the worst trade-off because I think the majority of people just want to check that a builder executes the commands as expected or that there's nothing horribly accidentally broken in their python edits to the builder config. But it's a wart I hope we can look to resolve in #331.