-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mlir][logo] add MLIR Sparsifier GIF assets to website #166
Conversation
Logos for the MLIR Sparsifier project, combining the MLIR logo with the concept of a sparse tensor. Credit: this beautiful MLIR Sparsifier GIF logos were designed by Yinying Li
Thanks Aart! |
Is there a license? |
Was there a license for the original MLIR logos? If so, we can release these under the same (assuming that is okay). |
@jpienaar to comment on licensing |
#132 is an ongoing discussion on making it clearer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder where it should go, e.g., the LogoAssets/logo is for the MLIR logo, I wonder if for subprojects it may make sense in LogoAssets/ instead (else folks could think its just the gif file format variant of the logo)
Yeah, good question. I tried to address this by using the extra /sparsifier level (I had to add the GIF top level since we were the first to provide a GIF logo). If you think LogoAssets/Sparsifier/GIF is better, happy to move it. |
LogoAssets/Sparsifier/GIF seems better for me. I suspect the author of the logo needs to transfer the copyright to the LLVM foundation? I don't know if a comment here is enough for this or what. |
No problem! I'm happy to transfer the copyright to the LLVM foundation. Please feel free to let me know if there's anything else you need. |
to make it clear this is a subproject. Below that we follow the same file type convention and thus use GIF for these moving logos.
Moved the assets into static/LogoAssets/Sparsifier/ to make it more clear this is a subproject. Below that we follow the same convention to use file types, so that gives static/LogoAssets/Sparsifier/GIF for these logos. @yinying-lisa-li thank you again for this beautiful artwork and your verbal transfer of copyright to LLVM foundation. |
Can we proceed with this PR, or do we need a full resolution of #132 first? |
Logos for the MLIR Sparsifier project, combining the MLIR logo with the concept of a sparse tensor.
Credit:
these beautiful MLIR Sparsifier GIF logos were designed by Yinying Li