Add typescript support to the library #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to bring typescript support to the library.
But, still there are some areas to be improved.
First issue is with using HTMLImageElement & CanvasRenderingContext2D. These are browser globals. So, it gives an error when running AVA tests. Also, this might give errors in Node Js apps. Can someone please, suggest a method to overcome this.
Also, in index.ts line 67, I have added validation in order to avoid npm build fail due to type mismatch. This error comes because the type of Image (in canvas) does not compatible with the type CanvasImageSource of drawImage method.
I am not very good in JS. So, if someone helps me, I can work on this further to finalize this PR and add TS support to this library.