GSSAPI (Kerberos) support #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Sorry for the delayed response, but this looks good! I'll take a closer look and merge soon. Thanks! |
|
Hello. |
jetersen
reviewed
Sep 12, 2019
Co-Authored-By: Joseph Petersen <[email protected]>
|
CI is red @artw :) |
|
can you take a look yourself? I have no idea why it CI needs that “CA” variable. Module works without it |
|
@magnuswatn , @jetersen please take a look at your CI. The reason this is failing is because some environment variables are not set which are needed by CI, not because there are errors in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I've added kerberos/spnego SSO support basically just by referencing requests-gssapi library.
Tested on MacOS 10.14 connecting to Windows 2016 Certificate Services.
Just need to have a valid TGT in the kerberos credential cache