-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve typing and change StyleLayer query call interface #5276
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5276 +/- ##
==========================================
+ Coverage 91.81% 91.83% +0.02%
==========================================
Files 282 282
Lines 38898 38908 +10
Branches 6825 6823 -2
==========================================
+ Hits 35716 35733 +17
+ Misses 3055 3047 -8
- Partials 127 128 +1 ☔ View full report in Codecov by Sentry. |
I've done a very simple change in the position matrix that is passed to the |
I was able to leverage the following method from the transform class: In order to use it I need to pass down the tileID, which is not a big deal since the tile is the caller in this case, and it know its own ID. |
Ignore my last comment, it breaks mercator related circle stuff... |
This is now ready for review, I'll add comments where I changed something that is not only types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a minor nit, otherwise this is a nice code improvement!
The problem is that get projection data doesn't support passing unwrapped. I tried changing that but it didn't go well. |
Launch Checklist
This is a pure refactoring step to add more types to the query code flows.
It also add the globe projection matrix to be passed down to the style layers that needs it, but it doesn't solve any problems with exiting code (mainly circle layer).
CHANGELOG.md
under the## main
section.