Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all browsers data for line-break CSS property #25330

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

queengooborg
Copy link
Contributor

This PR updates and corrects version values for all browsers for the line-break CSS property. The data comes from the mdn-bcd-collector project (v10.12.7).

Check out the collector's guide on how to review this PR.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/line-break

This PR updates and corrects version values for all browsers for the `line-break` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.12.7).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/line-break
@queengooborg queengooborg added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Dec 5, 2024
@github-actions github-actions bot added the size:m [PR only] 25-100 LoC changed label Dec 5, 2024
@caugner caugner self-requested a review December 6, 2024 13:47
@@ -118,24 +118,22 @@
],
"support": {
"chrome": {
"version_added": "≤83"
"version_added": "25"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that auto is the default value for this property, I'm not sure what the actual behavior is, so how do we determine whether a browser support this? By checking that we read this value if we set the value?

Otherwise I would expect this value to be supported from Chrome 1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that the default value changed from normal to auto in Chrome 25, so it's plausible that it's supported from this version: caugner/css-properties@aad719c

css/properties/line-break.json Outdated Show resolved Hide resolved
@@ -157,24 +155,22 @@
],
"support": {
"chrome": {
"version_added": "≤83"
"version_added": "25"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Chrome 25, -webkit-line-break: auto and -webkit-line-break: loose look the same (in fact all values look the same), which makes me think it isn't actually supported in Chrome 1+.

@@ -118,24 +118,22 @@
],
"support": {
"chrome": {
"version_added": "≤83"
"version_added": "25"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that the default value changed from normal to auto in Chrome 25, so it's plausible that it's supported from this version: caugner/css-properties@aad719c

css/properties/line-break.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants