Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS eslint rules cleanup #1749

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

Barabasbalazs
Copy link
Contributor

@Barabasbalazs Barabasbalazs commented Oct 21, 2024

Pull Request

Related issue

Fixes #1744

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 97.55245% with 14 lines in your changes missing coverage. Please review.

Project coverage is 97.03%. Comparing base (c49c0b5) to head (4c6678c).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
src/http-requests.ts 94.57% 9 Missing ⚠️
src/clients/client.ts 93.67% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1749      +/-   ##
==========================================
- Coverage   97.55%   97.03%   -0.52%     
==========================================
  Files          20       20              
  Lines        1513     1552      +39     
  Branches      319      328       +9     
==========================================
+ Hits         1476     1506      +30     
- Misses         37       46       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flevi29 flevi29 self-requested a review October 21, 2024 17:55
@flevi29 flevi29 added the maintenance Issue about maintenance (CI, tests, refacto...) label Oct 21, 2024
@flevi29
Copy link
Collaborator

flevi29 commented Oct 21, 2024

https://github.com/meilisearch/meilisearch-js/blob/main/eslint.config.js#L47-L59

Also remove these, except for @typescript-eslint/no-unused-vars.

Copy link
Collaborator

@flevi29 flevi29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above.

@flevi29 flevi29 marked this pull request as draft October 21, 2024 21:10
tests/search.test.ts Outdated Show resolved Hide resolved
src/clients/client.ts Outdated Show resolved Hide resolved
@Barabasbalazs Barabasbalazs marked this pull request as ready for review October 22, 2024 08:51
Copy link
Collaborator

@flevi29 flevi29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, jusqu'ici pour va bien.

@flevi29 flevi29 marked this pull request as draft October 22, 2024 08:54
@Barabasbalazs Barabasbalazs requested a review from flevi29 October 22, 2024 08:54
@flevi29
Copy link
Collaborator

flevi29 commented Oct 22, 2024

Let's leave this as a draft, because #1741 has to be merged first.

@Barabasbalazs Barabasbalazs marked this pull request as ready for review October 22, 2024 08:58
@Barabasbalazs Barabasbalazs marked this pull request as draft October 22, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn on TypeScript recommended ESLint rules
2 participants