Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile error #531

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

zhjwpku
Copy link

@zhjwpku zhjwpku commented Mar 18, 2024

I got the following compile error, this patch add libaio to the target's link libraries.

[ 43%] Linking CXX executable build_memory_index
/usr/bin/ld: ../src/libdiskann.so: undefined reference to `io_submit'
/usr/bin/ld: ../src/libdiskann.so: undefined reference to `io_getevents'
/usr/bin/ld: ../src/libdiskann.so: undefined reference to `io_setup'
/usr/bin/ld: ../src/libdiskann.so: undefined reference to `io_destroy'
collect2: error: ld returned 1 exit status
make[2]: *** [apps/CMakeFiles/build_memory_index.dir/build.make:99: apps/build_memory_index] Error 1
make[1]: *** [CMakeFiles/Makefile2:304: apps/CMakeFiles/build_memory_index.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
  • Does this PR have a descriptive title that could go in our release notes?
  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
    • Is the change to the API backwards compatible?
  • Should this result in any changes to our documentation, either updating existing docs or adding new ones?

Reference Issues/PRs

What does this implement/fix? Briefly explain your changes.

Any other comments?

I got the following compile error, this patch add libaio to the target's
link libraries.

```
[ 43%] Linking CXX executable build_memory_index
/usr/bin/ld: ../src/libdiskann.so: undefined reference to `io_submit'
/usr/bin/ld: ../src/libdiskann.so: undefined reference to `io_getevents'
/usr/bin/ld: ../src/libdiskann.so: undefined reference to `io_setup'
/usr/bin/ld: ../src/libdiskann.so: undefined reference to `io_destroy'
collect2: error: ld returned 1 exit status
make[2]: *** [apps/CMakeFiles/build_memory_index.dir/build.make:99: apps/build_memory_index] Error 1
make[1]: *** [CMakeFiles/Makefile2:304: apps/CMakeFiles/build_memory_index.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
```

Signed-off-by: Zhao Junwang <[email protected]>
@zhjwpku zhjwpku force-pushed the fix_compile_error branch from e722d36 to 66ec16c Compare March 19, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant