Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor filter code into its own class #593

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Refactor filter code into its own class #593

wants to merge 19 commits into from

Conversation

gopalrs
Copy link
Contributor

@gopalrs gopalrs commented Oct 21, 2024

Earlier, the PQFlashIndex class had a mish-mash of search + filter management (mostly load and filter existence checks). This PR moves filter management to a separate class to make it easy for us to enhance filter support.

  • Does this PR have a descriptive title that could go in our release notes?
  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
    • Is the change to the API backwards compatible?
  • Should this result in any changes to our documentation, either updating existing docs or adding new ones?

What does this implement/fix? Briefly explain your changes.

This is just code refactoring

Any other comments?

@gopalrs gopalrs requested review from rakri and MS-Renan October 21, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakri rakri rakri approved these changes

@MS-Renan MS-Renan Awaiting requested review from MS-Renan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gopalrs @rakri @gopal-msr