-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AzureRmWebAppDeploymentV5 to support OneDeploy for Linux App Service #20703
base: master
Are you sure you want to change the base?
Added AzureRmWebAppDeploymentV5 to support OneDeploy for Linux App Service #20703
Conversation
This PR depends on microsoft/azure-pipelines-tasks-common-packages#411 and should be merged only after that PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ShilpiRachna1
When we are selecting webapp of type Linux then actually in the UI of release pipeline we do not have "Additional argument" text box.
So, it would not be possible to give any arguments here or to select one deploy incremental deployment option.
"@types/q": "1.0.7", | ||
"agent-base": "^6.0.2", | ||
"azure-pipelines-task-lib": "4.11.0", | ||
"azure-pipelines-tasks-azure-arm-rest": "^3.246.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ShilpiRachna1
Please update here the package version of "azure-pipelines-tasks-azure-arm-rest".
…ShilpiRachna1/azure-pipelines-tasks into users/shilpirach/webappdeployv5
Fixed the UI. Please test again |
@z00sts - Since this is a new major version of the task, I am not sure if I can split the PR. If it helps, I have created another PR copying the newer changes to older version of the same task - that could help understand what is actually changing. https://github.com/microsoft/azure-pipelines-tasks/pull/20736/files Please let me know if there is anything else I can do to make the review process easier. Will make other changes as suggested. Thanks! |
@v-schhabra - This has been fixed. Now you would see the Additional Deployment options with deployment type dropdown and clean deployment checkbox |
Task name: AzureRmWebAppDeployment
Description:
PR #20736 shows changes in V5 w.r.t. V4.
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: N - Related issue is in ADO repository and has been shared with the reviewers
Checklist:
Localization changes: #20737