Compute best practices documentation update

[nteyan]

🛠️ Description

This update to the documentation page introduces new queries designed to retrieve detailed information about compute resources. The motivation behind these changes is to provide users with the tools needed to identify cost-saving opportunities and optimize resource usage. By leveraging these queries, users can gain insights into their compute resource allocation, enabling more efficient and cost-effective management.

📷 Screenshots

📋 Checklist

🔬 How did you test this change?

• 🤏 Lint tests
• 🤞 PS -WhatIf / az validate
• 👍 Manually deployed + verified
• 💪 Unit tests
• 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

• 🚨 This is a breaking change.
• 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

• ✅ Updated changelog (required for dev PRs)
• ➡️ Will add log in a future PR (feature branch PRs only)
• ❎ Log not needed (small/internal change)

📖 Did you update documentation?

• ✅ Public docs in docs (required for dev)
• ✅ Internal dev docs in src (required for dev)
• ➡️ Will add docs in a future PR (feature branch PRs only)
• ❎ Docs not needed (small/internal change)

[flanakin]

Do we want to track "Advisor" as a service under every category? It feels like that should only fall under General, right? At least, unless we see some very targeted action that we can recommend based on the service-specific queries, right?

[flanakin]

There should be spaces around =, after commas, and long lines should be broken up on multiple lines.

[flanakin]

nit: We should establish some KQL language standards. If you happen to know of any, we should document them in the wiki. No worries if you haven't.

[flanakin]

Suggested change

	| where tostring (properties.category) has "Cost"
	| where tostring(properties.category) has "Cost"

[flanakin]

Move each or to a new line so it's more readable online. Web should be in the Web category and not in Compute according to FOCUS service categories.

Suggested change

	| where properties.impactedField has "Compute" or properties.impactedField has "Container" or properties.impactedField has "Web"
	| where properties.impactedField has "Compute"
	or properties.impactedField has "Container"

[flanakin]

1. Make sure the queries are formatted correctly.
2. You're using a case-insensitive type filter on some lines and case-sensitive on the first where. Which is correct?
3. Let's always use single instead of double quotes.
4. Make sure table names are cased consistently. You have "resources" and "Resources".
5. Doesn't KQL use order by instead of sort by?

Suggested change

	Resources | where type == "microsoft.compute/virtualmachines"
	| extend osDiskId= tostring(properties.storageProfile.osDisk.managedDisk.id)
	| join kind=leftouter(resources
	| where type =~ 'microsoft.compute/disks'
	| where properties !has 'Unattached'
	| where properties has 'osType'
	| project OS = tostring(properties.osType), osSku = tostring(sku.name), osDiskSizeGB = toint(properties.diskSizeGB), osDiskId=tostring(id)) on osDiskId
	| join kind=leftouter(Resources
	| where type =~ 'microsoft.compute/disks'
	| where properties !has "osType"
	| where properties !has 'Unattached'
	| project sku = tostring(sku.name), diskSizeGB = toint(properties.diskSizeGB), id = managedBy
	| summarize sum(diskSizeGB), count(sku) by id, sku) on id
	| project vmId=id, subscriptionId, resourceGroup, OS, location, osDiskId, osSku, osDiskSizeGB, DataDisksGB=sum_diskSizeGB, diskSkuCount=count_sku
	| sort by diskSkuCount desc
	Resources
	| where type == 'microsoft.compute/virtualmachines'
	| extend osDiskId= tostring(properties.storageProfile.osDisk.managedDisk.id)
	| join kind=leftouter(
	Resources
	| where type =~ 'microsoft.compute/disks'
	| where properties !has 'Unattached'
	| where properties has 'osType'
	| project
	OS = tostring(properties.osType),
	osSku = tostring(sku.name),
	osDiskSizeGB = toint(properties.diskSizeGB),
	osDiskId=tostring(id)
	) on osDiskId
	| join kind=leftouter(
	Resources
	| where type =~ 'microsoft.compute/disks'
	| where properties !has "osType"
	| where properties !has 'Unattached'
	| project
	sku = tostring(sku.name),
	diskSizeGB = toint(properties.diskSizeGB),
	id = managedBy
	| summarize sum(diskSizeGB), count(sku) by id, sku
	) on id
	| project
	vmId = id,
	subscriptionId,
	resourceGroup,
	OS,
	location,
	osDiskId,
	osSku,
	osDiskSizeGB,
	DataDisksGB = sum_diskSizeGB,
	diskSkuCount = count_sku
	| order by diskSkuCount desc

[flanakin]

Shouldn't this be in the VMSS section? (Unless I missed it.)

[flanakin]

Move this to the Web category.

[flanakin]

Move this back to the top. Services should be sorted alphabetically.