-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Advisor and Resource Graph recommendations exports to Hubs #1130
base: features/recs
Are you sure you want to change the base?
Adding Advisor and Resource Graph recommendations exports to Hubs #1130
Conversation
value: 'Pipeline failed' | ||
type: 'Expression' | ||
} | ||
errorCode: 'ARGQueriesFailed' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make the prefix dynamic and pull from the JSON file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you be more specific? This activity is very generic, being there to raise a pipeline error only when at least one of the queries raised an error that is not attributable to a result with empty rows. This is needed to ensure the pipeline finishes successfully in case no cost recommendations were found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meanwhile understood what you meant. However, given the nature of each source type (ARG, ADX, etc.), error handling will probably be specific to the source type. We can discuss this further offline.
Co-authored-by: Michael Flanakin <[email protected]>
…b.com/helderpinto/finops-toolkit into helderpinto/dev/recommendationsexport
Co-authored-by: Michael Flanakin <[email protected]>
…b.com/helderpinto/finops-toolkit into helderpinto/dev/recommendationsexport
@flanakin, the ADF pipeline was refactored to become query type-agnostic. It is now prepared to deal with other query types in the future. There are still some unresolved conversations. Feel free to ping me offline or let's set up a meeting to discuss this further. |
🛠️ Description
This is the first PR in a series of PRs that will add Advisor and Resource Graph recommendations exports to Hubs. This PR includes the initial Advisor/ARG recommendations export and the schema for recommendations. It is compatible with Data Explorer ingestion. For this PR, we also fixed Western Europe timezones.
The upcoming PRs will address documentation, reporting, and granting permissions to the ADF identity at a higher scope, for the recommendations exports to succeed. Currently, Reader permissions have to be granted manually at the subscription or management group level.
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md
?📖 Did you update documentation?