Kernel Platform Worker Support #4605
Conversation
nibanks
added
OS: Windows (Kernel)
Area: Core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4605 +/- ##
==========================================
- Coverage 87.22% 86.67% -0.56%
==========================================
Files 56 56
Lines 17354 17354
==========================================
- Hits 15137 15041 -96
- Misses 2217 2313 +96 ☔ View full report in Codecov by Sentry. |
|
Looks like the kernel BVTs are crashing. I will try to investigate later. |
…icrosoft/msquic into nibanks/kernel-platform-worker
|
Something seems broken in netperf runs. I can't tell if it's because of this or not. Needs to be investigated before merging. |
|
Is the netperf result reliable? wsk related failure is really few. others are more |
|
Converted this back to draft, because we need to switch to using |
I suggest using the Zw variants for KM, unless QUIC is calling on behalf of the user mode thread calling QUIC, and all in the same thread context. |
| @@ -847,6 +846,11 @@ CxPlatDataPathInitialize( | |||
| } | |||
| } | |||
|
|
|||
| if (!CxPlatWorkerPoolLazyStart(WorkerPool, Config)) { | |||
There was a problem hiding this comment.
Launching threads here can be waste of resources? because pure winkernel doesn't use them.
Should be put in raw datapath initialization? but no need to fix in this PR I think.
Description
Extracts/refactors some of the code in #4023 to support platform worker threads, which is a prereq for kernel xdp support.
Testing
CI/CD
Documentation
N/A