Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define client spans for Generative AI agents #3

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

lmolkova
Copy link
Member

No description provided.

@@ -0,0 +1,5 @@
change_type: 'enhancement'
component: gen_ai
note: Yamlify gen_ai events and clean up examples.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, need to update

| [`gen_ai.request.presence_penalty`](/docs/attributes-registry/gen-ai.md) | double | The presence penalty setting for the GenAI request. | `0.1` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| [`gen_ai.request.stop_sequences`](/docs/attributes-registry/gen-ai.md) | string[] | List of sequences that the model will use to stop generating further tokens. | `["forest", "lived"]` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| [`gen_ai.request.temperature`](/docs/attributes-registry/gen-ai.md) | double | The temperature setting for the GenAI request. | `0.0` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| [`gen_ai.request.top_p`](/docs/attributes-registry/gen-ai.md) | double | The top_p sampling setting for the GenAI request. | `1.0` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| [`gen_ai.response.finish_reasons`](/docs/attributes-registry/gen-ai.md) | string[] | Array of reasons the model stopped generating tokens, corresponding to each generation received. | `["stop"]`; `["stop", "length"]` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| [`gen_ai.response.id`](/docs/attributes-registry/gen-ai.md) | string | The unique identifier for the completion. | `chatcmpl-123` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably want to keep it for the time being (for correlation with evals) and see how it can me merged with message id in the future

@@ -1,6 +1,7 @@
groups:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmolkova this agent semantic convention looks great, but seems this is mainly based on openai assistent. I did some research work for different agent frameworks at https://gyliu513.github.io/jekyll/update/2024/12/17/battle-of-ai-agent-frameworks.html , will think more for the semantic convention.

I was hoping I can probably borrow some idea from your PR and apply to open-telemetry#1657 , may I know why you did not create this PR in the repo https://github.com/open-telemetry/semantic-conventions but under a forked repo? Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we need to discuss and figure out how to draw the line between generic agent semantics vs vendor specific ones for different frameworks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthikscale3 +1, we can probably follow same pattern as LLM, we can have a common agent semantic convention, and each agent framework can extend based on the common agent semantic convention

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rule of 3 is bare minimum on specs IMHO (and I know nobody asked me). If a spec doesn't cover 3 diverse impls, it will break until then (probably still break after though ;))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants