feat: download browsers as TAR #34033
Open
+1,992
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mxschmitt
reviewed
Dec 18, 2024
packages/playwright-core/src/server/registry/oopDownloadBrowserMain.ts
Outdated
Show resolved
Hide resolved
| @@ -10,6 +10,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "extract-zip": "2.0.1", | |||
| "tar-fs": "^3.0.6", | |||
There was a problem hiding this comment.
I understand the library is popular, but its deps list seem to be excessive for what it does a little. Did we consider alternatives?
There was a problem hiding this comment.
Oh wow, "tar" is even more...
There was a problem hiding this comment.
Yes, we considered tar-fs, tar and writing our own. Writing our own turned out more complex than imagined, because webkit has very long path names and the format becomes tricky when that's involved. Of the three, tar-fs seemed the most focused.
mxschmitt
reviewed
Dec 19, 2024
| @@ -48,8 +48,8 @@ | |||
| "revision": "1011", | |||
| "installByDefault": true, | |||
| "revisionOverrides": { | |||
| "mac12": "1010", | |||
| "mac12-arm64": "1010" | |||
| "mac12": "1011", | |||
There was a problem hiding this comment.
whats the motivation for changing this?
There was a problem hiding this comment.
1010 doesn't have .tar.br, and 1010 is identical to 1011 in functionality
Test results for "tests 1"10 flaky37387 passed, 650 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our browsers are already available as
.tar.br. Compared to the current.ziparchives, the brotli tarballs are ~10-30% smaller. This PR makes us download brotli files for chromium and webkit.