fix Safari responds to the EnterKey from IM #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miku1958
force-pushed
the
Safari-IM-Eeter
branch
from
eae882c to
27685bf
Compare
JiuqingSong
reviewed
Dec 9, 2024
| @@ -181,7 +181,8 @@ export class EditPlugin implements EditorPlugin { | |||
| break; | |||
|
|
|||
| case 'Enter': | |||
| if (!hasCtrlOrMetaKey) { | |||
| if (!hasCtrlOrMetaKey && event.rawEvent.keyCode == 13) { | |||
There was a problem hiding this comment.
Interesting. If we are sure that keyCode will be 229 for IME enter, I prefer to check keyCode != 229 here which makes it more clear what it is doing.
Please add a const declaration for this key name and add comment
|
I created a PR to fix it from core plugin. #2905 |
JiuqingSong
reviewed
Dec 11, 2024
| /** | ||
| * Key code enumeration | ||
| */ | ||
| export const enum KeyCode { |
There was a problem hiding this comment.
Just put it back in EditPlugin.ts and no need to export it.
And use a regular const instead of const enum since const enum has a lot of problem.
miku1958
force-pushed
the
Safari-IM-Eeter
branch
from
6d432a7 to
3e908c1
Compare
JiuqingSong
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to repro: Press Enter when IM shows candidates
Screen.Recording.2024-12-09.at.13.14.33.mov
And its keycode is 229
Which is dead code
