Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2903 Handle watermark for IME #2913

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix #2903 Handle watermark for IME #2913

wants to merge 3 commits into from

Conversation

JiuqingSong
Copy link
Collaborator

When IME start (compositionstart event), we should hide watermark

When IME done (compositionend event), we need to check if editor is empty, because there can be two cases:

  1. Apply the input (we can hide watermark)
  2. Cancel the input (we need to check if it is empty)

It seems there is not a way to distinguish these two cases, so we always need to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyingbee2012 flyingbee2012 Awaiting requested review from flyingbee2012

@BryanValverdeU BryanValverdeU Awaiting requested review from BryanValverdeU

@ianeli1 ianeli1 Awaiting requested review from ianeli1

@juliaroldi juliaroldi Awaiting requested review from juliaroldi

@vinguyen12 vinguyen12 Awaiting requested review from vinguyen12

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JiuqingSong