fix: set DEBUG_MODE variable and add Conscrypt bypass #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR #38 broke the tools, at least on my setup: DEBUG_MODE is not defined, causing a reference error.
Replicate the issue
android-unpinner all -l -f ./apks/xxxxx.apkthen
frida -U -l tools/android-unpinner/android_unpinner/scripts/hide-debugger.js -l tools/android-unpinner/android_unpinner/scripts/httptoolkit-unpinner.js MyAppgives
Explanation
Unlike https://github.com/httptoolkit/frida-interception-and-unpinning, we don't have a config file in this project
Defining the variable fixes it and properly allows to apply patches
Bonus
Also
addedbrought back another common bypass (inspired by objection https://github.com/sensepost/objection/blob/master/agent/src/android/pinning.ts#L244)edit: turns out it was also deleted in #38 , see https://github.com/mitmproxy/android-unpinner/pull/38/files#diff-523754949d164f3759f5cfd8712b416590e6e9cf60810aa1e7ddf19346428793L147
I can make a dedicated PR for the bonus if you prefer