-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hotkeys to allow jumping back and forth between defined apps #1084
Open
paulpv
wants to merge
13
commits into
moonlight-stream:master
Choose a base branch
from
NightVsKnight:hotkeys
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,396
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpv
force-pushed
the
hotkeys
branch
11 times, most recently
from
October 17, 2023 19:07
2a4eafc
to
9093f9d
Compare
@cgutman While I am sure not bug free and probably needs a lot more changes, this PR is fully functional and cosmetically OK and is ready for your non-trivial review and consideration. |
Again, these are mostly just for debugging. I will comment out or remove these in the final code.
Also code commenting odd `StreamPreferences::reload()` behavior that I am seeing.
This first working version takes 1-3 seconds to destroy the current session and start a new session. I will work to improve this performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register global hotkeys for apps.
The proposed workflow is:
Add Hotkey
Ctrl-Alt-Shift-H
to go view the HotkeysControl-Alt-Shift-X
(X =1
to0
) to launch the pre-defined PC's app.This current code does NOT yet rearrange hotkeys in the Hotkeys view.
You change the order you have to delete them and add them in the order you want.