Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][useMediaQuery] Add warning for using useMediaQuery('print') #44790

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

good-jinu
Copy link

@good-jinu good-jinu commented Dec 17, 2024

Closes #17595

If these 'print' query warnings are deemed unnecessary, they will be removed.
Review them please.

- Explained that 'print' queries may not accurately reflect re-rendering changes in print environments.
- Added warning for using `print` query
@mui-bot
Copy link

mui-bot commented Dec 17, 2024

Netlify deploy preview

@material-ui/core: parsed: +0.05% , gzip: +0.11%
@material-ui/core/useMediaQuery: parsed: +2.22% , gzip: +3.07%
@material-ui/system: parsed: +0.35% , gzip: +0.53%
PigmentHidden: parsed: +0.46% , gzip: +0.70%
Hidden: parsed: +0.37% , gzip: +0.52%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against c1fbb29

@good-jinu good-jinu changed the title Add warning for using useMediaQuery('print') [material-ui][useMediaQuery]Add warning for using useMediaQuery('print') Dec 17, 2024
@zannager zannager requested a review from siriwatknp December 17, 2024 15:20
@aarongarciah aarongarciah added package: system Specific to @mui/system docs Improvements or additions to the documentation labels Dec 26, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][useMediaQuery]Add warning for using useMediaQuery('print') [material-ui][useMediaQuery] Add warning for using useMediaQuery('print') Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation hook: useMediaQuery package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui] useMediaQuery('print') doesn't work when print started from window.print
4 participants