-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Type check docs in CI #4560
base: master
Are you sure you want to change the base?
Conversation
@@ -8,10 +8,10 @@ const currentDirectory = url.fileURLToPath(new URL('.', import.meta.url)); | |||
|
|||
const require = createRequire(import.meta.url); | |||
|
|||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy mui/mui-x#11514
// @ts-ignore | ||
import { useColorSchemeShim } from 'docs/src/modules/components/ThemeContext'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source are in JavaScript.
@@ -1,38 +0,0 @@ | |||
/* eslint-disable import/no-unresolved */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems dead code
} | ||
|
||
function Heading({ hash, level: Level, title }: HeadingProps) { | ||
return <SectionTitle title={title} id={hash} level={Level} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was wrong: https://mui.com/toolpad/studio/reference/file-schema/
name: Check Typescript types | ||
command: pnpm check-types | ||
name: Tests TypeScript definitions | ||
command: pnpm typescript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy script naming convention from main repo.
I noticed this on #4344.
https://deploy-preview-4560--mui-toolpad-docs.netlify.app/toolpad/