-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extension deps and UI test CI workflows #1300
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
Thank you for making this pull request. Did you know? You can try it on Binder: or . Also, the version of Jupytext developed in this PR can be installed with
(this requires |
Signed-off-by: Mahendra Paipuri <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
- Coverage 97.02% 96.97% -0.05%
==========================================
Files 29 29
Lines 4501 4501
==========================================
- Hits 4367 4365 -2
- Misses 134 136 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@mwouts The failing conda test is due to outdated JupyterLab (4.2.5) in the test environment. This happens due to usage of GH actions cache instead of using most recent JupyterLab in the tests. Maybe a solution is to upgrade JupyterLab before running tests? |
@mwouts Most of the issues we faced on the playwright tests are due to not updating the npm dependencies. So, I added dependabot config to be able to bump dependencies automatically. We need to make sure that extension and test dependencies stay inline with JupyterLab. If the dependabot bumping fails for any dependency, tag me on the PR and I will look into it.