Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extension deps and UI test CI workflows #1300

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mahendrapaipuri
Copy link
Contributor

  • Bump npm dependencies of extension and playwright tests
  • Update playwright test specs and snapshots
  • Fix update-snapshot CI workflow
  • Add dependabot config to bump npm dependencies

@mwouts Most of the issues we faced on the playwright tests are due to not updating the npm dependencies. So, I added dependabot config to be able to bump dependencies automatically. We need to make sure that extension and test dependencies stay inline with JupyterLab. If the dependabot bumping fails for any dependency, tag me on the PR and I will look into it.

Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/mahendrapaipuri/jupytext.git@update_extension

(this requires nodejs, see more at Developing Jupytext)

Signed-off-by: Mahendra Paipuri <[email protected]>
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.97%. Comparing base (d0e5b7a) to head (bc727dc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
- Coverage   97.02%   96.97%   -0.05%     
==========================================
  Files          29       29              
  Lines        4501     4501              
==========================================
- Hits         4367     4365       -2     
- Misses        134      136       +2     
Flag Coverage Δ
external 75.03% <ø> (ø)
functional 88.35% <ø> (ø)
integration 77.27% <ø> (ø)
unit 66.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahendrapaipuri
Copy link
Contributor Author

@mwouts The failing conda test is due to outdated JupyterLab (4.2.5) in the test environment. This happens due to usage of GH actions cache instead of using most recent JupyterLab in the tests. Maybe a solution is to upgrade JupyterLab before running tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant