Remove domain for testing setup
#498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nebari-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
viniciusdc
reviewed
Aug 7, 2024
viniciusdc
reviewed
Aug 7, 2024
|
@viniciusdc thanks for the review, it feels less clunky now. Let me know if theres anything else :) |
|
Nice @asmacdo thanks, I will have another look later today 🚀 |
|
Hi @asmacdo sorry for the delay on this, got a busy ending of August. I plan on taking another look at this during this week. I noticed that there seems to be a conflict with some files above, if you had the time can you fix these? Otherwise, if you don't mind I can amend those as well. |
viniciusdc
reviewed
Sep 26, 2024
Related: nebari-dev/nebari#2555 Thanks @vinicusdc for the suggestion nebari-dev/nebari#2555 (comment)
asmacdo
force-pushed
the
local-deploy-explain-domain
branch
from
5bfffec to
c43d203
Compare
|
I clumsily combined GH suggestions with local pushes, sorry for the awkwardness, I think its correct now. |
|
@viniciusdc can you take another look at this so we can get it over the finish line? |
viniciusdc
reviewed
Nov 1, 2024
viniciusdc
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #496 to avoid merge conflicts. If you prefer, we could just merge this one and close the other.
Related: nebari-dev/nebari#2555
Thanks @vinicusdc for the suggestion nebari-dev/nebari#2555 (comment)
What does this implement/fix?
The local deployment docs include setting
domain, which doesn't work out of the box without setting up DNS, which I've also added a link to.Put a
xin the boxes that applyAccess-centered content checklist
Text styling
H1or#in markdown).Any other comments?
Local deployment with
kindseems like the entrypoint for prospective users. Making this doc work smoothly out-of-the-box should be helpful I hope :)