-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: nushell module configuration overwrites default basic configuration #5527
Comments
I do think this is intended behavior as the name of either But it's a little bit unfortunate, that nushell somewhat "relies" on a default file at that path as well to provide the expected UX. I think the defaults are too long to be included in this module, as I think it will be very annoying to keep this up-to-date. So all in all I think this is a wontfix, but we can warn the user in the docs, and link them to where the defaults are, when they use the nushell module (or programs.nushell.configFile.source = builtins.fetchurl {
url = "https://raw.githubusercontent.com/nushell/nushell/f2f4b83886d0060b93eef49baac1bb3ce18d42af/crates/nu-utils/src/sample_config/default_config.nu";
sha256 = "sha256:0mdbl66g8ivhm4yn2rasswdcxrxijmsa27a75kkblfbjbymnb46w";
}; |
Something like useDefaultConfig sounds good also, maybe just an option to disable the banner? (since I only want to change that from the default config anyways) |
For future reference: xdg.configFile."nushell/config.nu".text = builtins.readFile "${pkgs.fetchFromGitHub (with pkgs.nushell.src; {owner=owner; repo=repo; rev=rev; hash=outputHash;})}/crates/nu-utils/src/sample_config/default_config.nu" + ''
# Your custom config.nu overrides
'';
xdg.configFile."nushell/env.nu".text = builtins.readFile "${pkgs.fetchFromGitHub (with pkgs.nushell.src; {owner=owner; repo=repo; rev=rev; hash=outputHash;})}/crates/nu-utils/src/sample_config/default_env.nu" + ''
# Your custom env.nu overrides
''; Should work. |
Are you following the right branch?
Is there an existing issue for this?
Issue description
So the home-manager module for nushell is actually destructive, which is not an idea as it overwrites the original nushell configuration which most users probably don't want since it breaks nushell. Rather, users want to most likely append the config to add their config.
My config for clarity is:
Maintainer CC
@Philipp-M
System information
The text was updated successfully, but these errors were encountered: