Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

direnv: hopefully final nushell fix #5896

Conversation

K900
Copy link
Contributor

@K900 K900 commented Sep 26, 2024

Description

I hate this.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@K900 K900 force-pushed the nushell-direnv-fix-hopefully-for-the-last-time branch from bac1d69 to d92e272 Compare September 26, 2024 20:16
@rycee rycee force-pushed the nushell-direnv-fix-hopefully-for-the-last-time branch from d92e272 to ffe2d07 Compare September 26, 2024 20:52
@rycee rycee merged commit ffe2d07 into nix-community:master Sep 26, 2024
3 checks passed
@rycee
Copy link
Member

rycee commented Sep 26, 2024

I fixed the test case and merged to master now. Hope it works better now! Have to go sleep so will check back tomorrow.

@nyabinary
Copy link

This breaks nushell as it overrides the default env.nu breaking the behavior of nushell in general isn't there a way to just append the direnv stuff instead of overwriting the entire env.nu file?

@K900
Copy link
Contributor Author

K900 commented Sep 27, 2024

No it doesn't? That's why the mkAfter is there.

@nyabinary
Copy link

No it doesn't? That's why the mkAfter is there.

#5527
nushell/nushell#13174

Does for me I just want to add a alias and stuff in my config and it overrides the entire default env.nu already in place instead of appending to it.

@K900
Copy link
Contributor Author

K900 commented Sep 27, 2024

That's unrelated to this change though?

@nyabinary
Copy link

That's unrelated to this change though?

But the direnv thing is broken in general because if you enable the direnv support for nushell it currently breaks nushell:
image
Pops up a nu::shell::non_zero_exit_code when normally its not supposed to do that :P

@K900
Copy link
Contributor Author

K900 commented Sep 27, 2024

That has nothing to do with direnv, and it is supposed to do that starting with Nushell 0.98 (see the original chain of PRs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants