Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove flaky designation #56369

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Dec 26, 2024

Remove test-inspector-async-stack-traces-set-interval flaky designation.

Refs: #50243

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 26, 2024
Remove test-inspector-async-stack-traces-set-interval flaky designation.

Refs: nodejs#50243
@lpinca lpinca force-pushed the remove/flaky-test-inspector-async-stack-traces-set-interval branch from 2846e12 to 7c83f5e Compare December 26, 2024 14:42
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 26, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.56%. Comparing base (1d1d8f2) to head (7c83f5e).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56369   +/-   ##
=======================================
  Coverage   88.55%   88.56%           
=======================================
  Files         657      657           
  Lines      190658   190658           
  Branches    36585    36591    +6     
=======================================
+ Hits       168839   168847    +8     
+ Misses      14999    14995    -4     
+ Partials     6820     6816    -4     

see 31 files with indirect coverage changes

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 28, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 28, 2024
@nodejs-github-bot nodejs-github-bot merged commit cef15f8 into nodejs:main Dec 28, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in cef15f8

@lpinca lpinca deleted the remove/flaky-test-inspector-async-stack-traces-set-interval branch December 29, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants