fix(js): Update typescript plugin check for buildable projects #29431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ndcunningham
force-pushed
the
fix/js-plugin-non-buildable-libs
branch
from
6c54f95 to
42d8368
Compare
|
View your CI Pipeline Execution ↗ for commit dac5900.
☁️ Nx Cloud last updated this comment at |
ndcunningham
force-pushed
the
fix/js-plugin-non-buildable-libs
branch
3 times, most recently
from
84f0e02 to
17e660c
Compare
jaysoo
reviewed
Dec 19, 2024
jaysoo
reviewed
Dec 19, 2024
ndcunningham
force-pushed
the
fix/js-plugin-non-buildable-libs
branch
from
17e660c to
832a1c9
Compare
jaysoo
approved these changes
Dec 19, 2024
ndcunningham
force-pushed
the
fix/js-plugin-non-buildable-libs
branch
from
9f3b013 to
826be61
Compare
FrozenPandaz
requested changes
Dec 19, 2024
ndcunningham
force-pushed
the
fix/js-plugin-non-buildable-libs
branch
from
826be61 to
a69396b
Compare
ndcunningham
force-pushed
the
fix/js-plugin-non-buildable-libs
branch
from
a69396b to
7112c2b
Compare
leosvelperez
requested changes
Dec 20, 2024
…precedence for outfile & outDir also exports and main or module
ndcunningham
force-pushed
the
fix/js-plugin-non-buildable-libs
branch
from
f282f74 to
dac5900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, we use
rootDirto check if the project is buildable. This might not be correct in the case where the transpiled files are inside source.Expected Behavior
It should work the for projects as long as the main / exports files are not source files.
Related Issue(s)
Fixes #