cleanup(core): move esbuild to use tinyglobby #29453
Open
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 97a5868.
☁️ Nx Cloud last updated this comment at |
29 tasks
benmccann
approved these changes
Dec 21, 2024
JamesHenry
requested changes
Dec 23, 2024
An alternative to nrwl#28037, switches the esbuild package to use `tinyglobby` instead of `fast-glob`. This improves performance a fair chunk and reduces install complexity/size.
|
@JamesHenry this should be all good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #28037, switches the esbuild package to use
tinyglobbyinstead offast-glob.This improves performance a fair chunk and reduces install complexity/size.
cc @benmccann @JamesHenry